enhancement: vision icon hub model list #6251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Changes requested ❌
Reviewed everything up to 68f8c2d in 2 minutes and 20 seconds. Click for details.
- Reviewed
69lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. web-app/src/routes/hub/index.tsx:680
- Draft comment:
Ensure the translation keys are consistent—original code used t('hub:tools') and t('hub:vision') but now the tooltips use t('tools') and t('vision'). - Reason this comment was not posted:
Confidence changes required:50%<= threshold50%None
2. web-app/src/routes/hub/index.tsx:672
- Draft comment:
If these icons are meant to be interactive or focusable, consider using a focusable element (e.g. a button or adding tabindex) instead of a plain div within TooltipTrigger for improved accessibility. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_e4J1FlNGMiRGwC4X
You can customize 
Barecheck - Code coverage reportTotal: 37.08%Your code coverage diff: -0.04% ▾ Uncovered files and lines
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This pull request enhances the model listing UI in
web-app/src/routes/hub/index.tsxby introducing tooltips for icons and adding a new visual indicator for models with vision capabilities. The changes improve user experience by making the interface more informative and accessible.UI enhancements:
IconToolicon to display a description when hovered, improving clarity for users about model tools.IconEyeicon with tooltip labeled "vision" for models that support vision (num_mmproj > 0), providing a clear visual indicator for this capability.Component imports:
Tooltip,TooltipContent,TooltipProvider,TooltipTrigger) and theIconEyeicon to support the new UI features.Fixes Issues
Self Checklist
Important
Enhance model listing UI in
index.tsxwith tooltips andIconEyefor vision models.IconToolinindex.tsxto display descriptions on hover.IconEyewith tooltip "vision" for models withnum_mmproj > 0inindex.tsx.Tooltip,TooltipContent,TooltipProvider,TooltipTrigger, andIconEyeinindex.tsx.This description was created by
for 68f8c2d. You can customize this summary. It will automatically update as commits are pushed.